Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BE8A2200B6D for ; Tue, 9 Aug 2016 01:26:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BD2C5160AB3; Mon, 8 Aug 2016 23:26:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0D48A160A91 for ; Tue, 9 Aug 2016 01:26:11 +0200 (CEST) Received: (qmail 92067 invoked by uid 500); 8 Aug 2016 23:26:11 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 92056 invoked by uid 99); 8 Aug 2016 23:26:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Aug 2016 23:26:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9C104C3051 for ; Mon, 8 Aug 2016 23:26:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id cAd5ieiQrEMK for ; Mon, 8 Aug 2016 23:26:07 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 517615FBB2 for ; Mon, 8 Aug 2016 23:26:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u78NQ4qO021881; Mon, 8 Aug 2016 23:26:04 GMT Message-Id: <201608082326.u78NQ4qO021881@ip-10-146-233-104.ec2.internal> Date: Mon, 8 Aug 2016 23:26:04 +0000 From: "Matthew Jacobs (Code Review)" To: Jim Apple , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Alex Behm , Tim Armstrong Reply-To: mj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2581=3A_LIMIT_can_be_propagated_down_into_some_aggregations=0A?= X-Gerrit-Change-Id: I59c5b7af7a73ccdbc5496b28eacb9b6859d202bc X-Gerrit-ChangeURL: X-Gerrit-Commit: db124554f4da4534b62a1bec8f768bc3669012b1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Mon, 08 Aug 2016 23:26:12 -0000 Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations ...................................................................... Patch Set 2: (2 comments) A few nits to add to Tim's comments which haven't been addressed in rev2 yet... http://gerrit.cloudera.org:8080/#/c/3822/2/be/src/exec/partitioned-aggregation-node.h File be/src/exec/partitioned-aggregation-node.h: PS2, Line 296: int64_t const? PS2, Line 339: group_count_ = 0 A nice new feature of c++11, but since we initialize in the initialization lists it'd be best to put it there for consistency. -- To view, visit http://gerrit.cloudera.org:8080/3822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59c5b7af7a73ccdbc5496b28eacb9b6859d202bc Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes