impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuanhao Luo (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3945: Forbid create text table with nonsensical delimiter combinations.
Date Thu, 04 Aug 2016 06:42:18 GMT
Yuanhao Luo has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3839

Change subject: IMPALA-3945: Forbid create text table with nonsensical delimiter combinations.
......................................................................

IMPALA-3945: Forbid create text table with nonsensical delimiter combinations.

This commit promoting warnings to AnalysisException to fix test fail
of two corner cases: field delimiter and escape character have the same
value and line delimiter and escape character have the same value.
Besides, this commit add some tests for these two corner cases.

Change-Id: I836b45f930e680ea03274405b90b1ee14822152b
---
M fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java
M tests/query_test/test_delimited_text.py
2 files changed, 41 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/3839/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I836b45f930e680ea03274405b90b1ee14822152b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>

Mime
View raw message