impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3946: fix MemPool integrity issues with empty chunks
Date Tue, 09 Aug 2016 04:14:51 GMT
Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3838

Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks
......................................................................

IMPALA-3946: fix MemPool integrity issues with empty chunks

There were various rare code paths that results in the MemPool failing
its own internal integrity checks. This required various small fixes to
ensure that the MemPool was always valid even when there were empty
chunks for various reasons (either from calling Clear() or
ReturnPartialAllocation()).

Testing:
Added unit tests for three secenarios where the integrity check failed.
Also ran fuzz tester to confirm that the original issue was fixed.

Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346
---
M be/src/runtime/mem-pool-test.cc
M be/src/runtime/mem-pool.cc
M be/src/runtime/mem-pool.h
3 files changed, 127 insertions(+), 70 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/3838/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message