impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Behm <alex.b...@cloudera.com>
Subject Re: Code formatting with clang-format
Date Tue, 16 Aug 2016 07:00:37 GMT
+1 for abandoning some of our style idiosyncrasies in favor of
easy-to-maintain automation

On Mon, Aug 15, 2016 at 4:57 PM, Henry Robinson <henry@cloudera.com> wrote:

> I think this is great - really useful to have. There are some small
> deviations from our traditional style (see the review for a couple of
> them). They really don't bother me, and I think it's much better to have
> automated formatting than to hang on to the position of a : in a for()
> statement :) But I asked Jim if he'd start a thread here to check if others
> agree.
>
> On 15 August 2016 at 15:18, Jim Apple <jbapple@cloudera.com> wrote:
>
> > I would like to have a clang-format config file in our directory to help
> > new contributors understand how to format code and have a tool to do it
> for
> > them. Through the time I've been sending patches I've been accumulating a
> > .clang-format file that seems to minimize the style comments I get. You
> can
> > see it here:
> >
> > https://gerrit.cloudera.org/#/c/3886
> >
> > And you can save it and upload it to play with here:
> >
> > http://zed0.co.uk/clang-format-configurator/
> >
> > I would love to hear your thoughts.
> >
>
>
>
> --
> Henry Robinson
> Software Engineer
> Cloudera
> 415-994-6679
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message