impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch
Date Wed, 31 Aug 2016 20:11:23 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4181/2/be/src/runtime/row-batch.h
File be/src/runtime/row-batch.h:

PS2, Line 384: const RowDescriptor& row_desc_;
Is this always safe ?


-- 
To view, visit http://gerrit.cloudera.org:8080/4181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27c05090ee8b9dd9d650a5587a3ae42839aa0008
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message