impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE
Date Wed, 31 Aug 2016 16:32:21 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3308: Get expr-test passing on PPC64LE
......................................................................


Patch Set 1:

Actually I think we should go further to prevent such bugs in future. Currently it's still
possible to create an invalid ExprValue just by copying it.

Could you add DISALLOW_COPY_AND_ASSIGN(ExprValue) to ExprValue (you'll see other examples
in the codebase) and then update all of the constructions to use the in-place Init() pattern.

-- 
To view, visit http://gerrit.cloudera.org:8080/4186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4504ee6a52a085f530aadfcfa009bacb83c64787
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: segelyang <zhizhiy@cn.ibm.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message