impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.
Date Wed, 31 Aug 2016 01:07:45 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py.
......................................................................


Patch Set 3:

(1 comment)

Thanks for the fast turnaround, Michael!

http://gerrit.cloudera.org:8080/#/c/4155/3/tests/conftest.py
File tests/conftest.py:

PS3, Line 284:   return first_db_name
> I don't really like that we return a db name but more than one DB is create
Agreed. This is definitely not an ideal solution but it still seems like an improvement. Step
by step :)


-- 
To view, visit http://gerrit.cloudera.org:8080/4155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf667dd5e960768879c019e2037cf48ad4e4241b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message