impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4020: Catalog update can fail due to database creation/deletion in hive
Date Mon, 29 Aug 2016 21:53:08 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4020: Catalog update can fail due to database creation/deletion in
hive
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4161/1/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java:

Line 568:             try {
Indentation off


Line 601:           catch (NoSuchObjectException e)  {
You might want to add a comment here on when we catch this exception.


Line 602:             LOG.error("Error loading metadata for" + dbName);
IMO, this should be a WARN of lesser, given the DB has probably been deleted outside of Impala
and is a genuine case. Also may be format it to LOG.warn("Encountered an exception while invalidating
metadata for database: " + dbName, e) ? (just to signify its not really an error and also
log the stack trace for better debugging.)


-- 
To view, visit http://gerrit.cloudera.org:8080/4161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic228efbcceb9ef6c165d0d9aeef7202581e3e46a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message