impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()
Date Fri, 26 Aug 2016 00:24:10 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4125/2/fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java
File fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java:

PS2, Line 375: Copies the source file to a destination path on the local filesystem and returns
true
             :    * if successful.
> Can you add a comment here about errorTrace? (And that it is the full stack
Done


PS2, Line 390: Return true if the path can be reached, false for all other cases
             :    * File doesn't exist, cannot access the FileSystem, etc.
> Also please comment here about errorMsg. It'd be good to call out this is a
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5664a75aa837951de1d5dcc90e43bd8f313736b8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message