impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3905: Add single-threaded scan node.
Date Thu, 25 Aug 2016 23:57:23 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3905: Add single-threaded scan node.

Patch Set 1:


A few more comments. I think I understand the core of this a bit better - will wait for the
next patch now.
File be/src/exec/

Line 57: 
We aren't accounting time in Open() in the same way we do in the non-mt scan node.

Line 61:   if (!initial_ranges_issued_) IssueInitialScanRanges(state);
Add a brief comment about why we don't do this in Open() - I see there's a similar comment

Line 63:   if (ReachedLimit()) {
Is it a problem that we don't call StopAndFinalizeCounters() on this code path?

PS1, Line 81: reinterpret_cast
Not your change but I think these casts of meta_data() here and should probably be static_casts
instead because that's generally safe/more restrictive.

E.g. see
File be/src/exec/

Line 194:   SCOPED_TIMER(runtime_profile_->total_time_counter());
I guess we didn't track this before.
File be/src/exec/hdfs-scan-node.h:

Line 60: /// An HdfsScanNode may expect to receive runtime filters produced elsewhere in the
It seems like some of this comment (at least about the filters) should go into the base class.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I98cc7f970e1575dd83875609985e1877ada3d5e0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message