impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()
Date Thu, 25 Aug 2016 19:58:45 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4125/1/fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java
File fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java:

PS1, Line 377: copyToLocal(Path source, Path dest) 
It looks like the caller of this is logging as well, it just just have the error message.
Further, it's unfortunate to have so a number of different ways of handling errors in this
file. How about doing the same thing that the fn below (isPathReachable) does, have an error_msg
in/out parameter which has the error written to it, then the caller can log as it already
does and include the detailed error message.


-- 
To view, visit http://gerrit.cloudera.org:8080/4125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5664a75aa837951de1d5dcc90e43bd8f313736b8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message