impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3979: Fix dynamic linking for Impala
Date Thu, 25 Aug 2016 15:35:25 GMT
Tim Armstrong has submitted this change and it was merged.

Change subject: IMPALA-3979: Fix dynamic linking for Impala
......................................................................


IMPALA-3979: Fix dynamic linking for Impala

When building Impala, the user can choose between two different
build modes: static and dynamically linked libraries. The first
one is used for release builds, while the latter one is used
mainly locally for developers to shorten build times.

However, for some time now, the shared build has been broken in
some configurations. This patch fixes this issue. The main
solution is to move the webserver into the Util library and to
remove the manual linking of Util into the error-utils-test.

Change-Id: I2fb1efd600bfaf17de730186fc80a0dbd976a049
Reviewed-on: http://gerrit.cloudera.org:8080/4108
Tested-by: Internal Jenkins
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
---
M be/CMakeLists.txt
M be/src/util/CMakeLists.txt
2 files changed, 8 insertions(+), 12 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/4108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2fb1efd600bfaf17de730186fc80a0dbd976a049
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Martin Grund <grundprinzip@gmail.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Martin Grund <grundprinzip@gmail.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message