impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3944: Fix crash in SimpleScheduler
Date Wed, 24 Aug 2016 17:53:36 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-3944: Fix crash in SimpleScheduler
......................................................................


Patch Set 2:

(1 comment)

Thanks for the review. Please see PS3.

http://gerrit.cloudera.org:8080/#/c/4102/2/be/src/scheduling/simple-scheduler.cc
File be/src/scheduling/simple-scheduler.cc:

Line 266:         return;
> should this be return or continue? seems like we're ignoring a lot more in 
Oh, sorry. Good catch.


-- 
To view, visit http://gerrit.cloudera.org:8080/4102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c2c58c2f9e7de0936aba03dcce86cdc4b31a866
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message