impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3944: Fix crash in SimpleScheduler
Date Wed, 24 Aug 2016 17:31:33 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-3944: Fix crash in SimpleScheduler
......................................................................


Patch Set 1:

(2 comments)

Thank you for the review, please see PS 2.

http://gerrit.cloudera.org:8080/#/c/4102/1/be/src/scheduling/simple-scheduler.cc
File be/src/scheduling/simple-scheduler.cc:

Line 261:         VLOG(1) << "Ignoring subscription request with empty IP address from
subscriber: "
> describe in comment why this would be empty.
Done


Line 262:           << be_desc.address;
> indent 4 spaces
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c2c58c2f9e7de0936aba03dcce86cdc4b31a866
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message