impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3988: Only use first 96 bits of query id
Date Wed, 24 Aug 2016 00:18:13 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3988: Only use first 96 bits of query id
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4065/8/be/src/util/uid-util.h
File be/src/util/uid-util.h:

PS8, Line 51: const
> what's the advantage in this context?
Tells the reader and the compiler that this is really and truly a constant (i.e. not dependent
on any variable), and is available for use in other constexpr contexts; for example template
parameters. At this point it's mostly a readability aid.


Line 55:   memcpy(&result.hi, &uuid.data[0], 8);
> what is the concern?
Seemed more readable as an assignment to me. But the compiler special-cases the 8-byte copy
AFAICT, so not worth changing.


-- 
To view, visit http://gerrit.cloudera.org:8080/4065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia56a03ed9a1d7e77c72b66a01cd48c5b6bf3624f
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message