impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Ivanfi (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4006: impala-config.sh contains dangerous rm -rf statements
Date Tue, 23 Aug 2016 10:31:31 GMT
Zoltan Ivanfi has posted comments on this change.

Change subject: IMPALA-4006: impala-config.sh contains dangerous rm -rf statements
......................................................................


Patch Set 1:

(1 comment)

> I believe you can avoid the spaces-in-lists-of-files problems using
 > bash arrays but I don't know if it's worth the effort

The problem with bash arrays is that they can not be exported, their scope is limited to the
current shell process.

http://gerrit.cloudera.org:8080/#/c/4078/1/bin/run-all-tests.sh
File bin/run-all-tests.sh:

PS1, Line 101: LOG_DIR="${IMPALA_EE_TEST_LOGS_DIR}"
> It's used by run-step
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7503794180dee99eeb979e67f34e3b2edade70fe
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zoltan Ivanfi <zi@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message