impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3820: Handle linkage errors while loading Java UDFs in Catalog
Date Mon, 22 Aug 2016 16:37:24 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3820: Handle linkage errors while loading Java UDFs in Catalog
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3567/4/tests/test-hive-udfs/pom.xml
File tests/test-hive-udfs/pom.xml:

Line 29:     <dependency>
> Maybe we can make the throwing of Error conditional for example by inspecti
Sorry for the delay here. 

- We don't seem to be setting a vm name, most likely because we launch the jvm using JNI and
not with a direct java class invocation. Inspecting the VM options, nothing seems to be uniquely
related to Impalad/Catalogd that we can extract and rely on.

- I tried looking for a way to force a vm name, but none worked. Also I thought of using static
classes like RuntimeState to check if its a Catalog jvm but again that sounds more like a
workaround and polluting the code.


-- 
To view, visit http://gerrit.cloudera.org:8080/3567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1109614f1617caa9bb27e8c151e902aae71a6b41
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message