impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3988: Only use first 96 bits of query id
Date Sat, 20 Aug 2016 19:28:57 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-3988: Only use first 96 bits of query id
......................................................................


Patch Set 6:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4065/6/be/src/scheduling/simple-scheduler.cc
File be/src/scheduling/simple-scheduler.cc:

PS6, Line 505: int
Will there be a chance of overflow here ? Should we use int64_t instead ?

Once intance_idx > (1 << 31) - 1, it will be negative so instance_idx > MAX_FRAGMENT_INSTANCE_IDX
will always be false. We may end up wrapping and not catch the problem.


PS6, Line 509:   
nit: wrong indentation


http://gerrit.cloudera.org:8080/#/c/4065/6/be/src/util/uid-util-test.cc
File be/src/util/uid-util-test.cc:

Line 42:   }
It may be worth having some negative test cases in which the instance_id exceeds the 32-bit
width ?


http://gerrit.cloudera.org:8080/#/c/4065/6/be/src/util/uid-util.h
File be/src/util/uid-util.h:

PS6, Line 70: std::numeric_limits<int>::max()
Do we support up to (1L << 31) -2 number of instances ? Is there a reason why we cannot
use all 32-bit for instance id ?


PS6, Line 75: int
Does this have the same overflow problem here ?


-- 
To view, visit http://gerrit.cloudera.org:8080/4065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia56a03ed9a1d7e77c72b66a01cd48c5b6bf3624f
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message