impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose
Date Fri, 19 Aug 2016 22:06:52 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address,
overly verbose
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3994/2/be/src/util/webserver.cc
File be/src/util/webserver.cc:

PS2, Line 224: If GetHostname() returns an error, hostname will be 0.0.0.0
> I assign hostname in L222. So if GetHostname() returns an error, hostname w
GetHostname() makes no guarantees about what happens to the argument in the error case.


-- 
To view, visit http://gerrit.cloudera.org:8080/3994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d167b66f2dd8629e40a7094d21ea7ce6b43d23b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message