impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathy Sun (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page
Date Fri, 19 Aug 2016 19:16:15 GMT
Kathy Sun has uploaded a new patch set (#8).

Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page
......................................................................

IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

The /memz page tried to add JVM metrics even when they didn't exist for
all daemons, not just Impala. This led to a crash when they tried to
access ExecEnv::GetInstance() without an initialised ExecEnv at
statestored and catalogd

To fix, changed the memz handler method to take an optional metric
group, provided by the caller.  memz handler will check the existence of
the metric group.

Used C++11 lambdas rather than boost::bind to help simplify the code.

Testing: Ran locally and looked at impalad/memz, statestored/memz
and catalogd/memz

Add a test file test_web_pages.py to test sending request to /memz on
impalad / statestored / catalogd

Change-Id: If59b10f20044d1a468f27810a3029fe18fb19f29
---
M be/src/catalog/catalogd-main.cc
M be/src/runtime/data-stream-mgr.cc
M be/src/runtime/exec-env.cc
M be/src/scheduling/simple-scheduler.cc
M be/src/service/impala-server.cc
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestored-main.cc
M be/src/util/default-path-handlers.cc
M be/src/util/default-path-handlers.h
M be/src/util/memory-metrics.cc
M be/src/util/metrics-test.cc
M be/src/util/metrics.cc
M be/src/util/metrics.h
A tests/webserver/test_web_pages.py
M www/memz.tmpl
15 files changed, 96 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/3998/8
-- 
To view, visit http://gerrit.cloudera.org:8080/3998
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If59b10f20044d1a468f27810a3029fe18fb19f29
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Kathy Sun <kathy.sun@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Kathy Sun <kathy.sun@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message