impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-(3895,3859): Don't log file data on parse errors
Date Fri, 19 Aug 2016 18:21:20 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-(3895,3859): Don't log file data on parse errors
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4020/2/be/src/exec/hdfs-scanner.cc
File be/src/exec/hdfs-scanner.cc:

PS2, Line 635: TO
> weird caps - should be lower case?
Done


http://gerrit.cloudera.org:8080/#/c/4020/2/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

Line 328:         replace_filenames_with_placeholder = True
> I think like this is getting big enough to be its own function. E.g. verify
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a604f8784a9ff7b4bf878f82ee7f56697df3272
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message