impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page
Date Fri, 19 Aug 2016 17:06:28 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page
......................................................................


Patch Set 7:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/3998/7/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

PS7, Line 17: #
            : # Verification of impalad metrics after a test run.
remove


PS7, Line 21: from tests.common.errors import Timeout
is this used?


PS7, Line 27: (\
remove the \, and try and put some of the parameters onto this line.


PS7, Line 31: resp.raise_for_status()
does this raise an error when status != 200? If so you don't need the checks on lines 41,
43, 45. Maybe you could check if the contents of the webpage has what you're expecting?


PS7, Line 35: """request web page /memz at imapalad / statestored / catalogd."""
I'd remove this, it doesn't tell the reader anything that's not in the test comments.


-- 
To view, visit http://gerrit.cloudera.org:8080/3998
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If59b10f20044d1a468f27810a3029fe18fb19f29
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Kathy Sun <kathy.sun@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Kathy Sun <kathy.sun@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message