impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3090: always log memory limit errors
Date Thu, 18 Aug 2016 20:15:10 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-3090: always log memory limit errors
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4049/1/be/src/runtime/mem-tracker.h
File be/src/runtime/mem-tracker.h:

PS1, Line 350:  int64_t failed_allocation)
Thanks for adding the comment. It may be worth setting the default value of 'failed_allocation'
to 0 so some callsites of this function don't have to pass 0.


-- 
To view, visit http://gerrit.cloudera.org:8080/4049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5ec5572b0e26898da352b7e6b11eb01c6edb2e5
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message