impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3964: Fix crash when a count(*) is performed on a nested collection.
Date Fri, 12 Aug 2016 04:28:59 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3964: Fix crash when a count(*) is performed on a nested collection.
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3940/3/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 574:       dst_batch->tuple_data_pool()->AcquireData(scratch_batch_->mem_pool(),
false);
> Sorry for the late review. If we are materializing a collection with empty 
We don't need to transfer in that case. However, we do need to transfer in case we are using
the legacy aggs/joins because in that case we will have allocated the scratch batch's tuple
pointers from the scratch batch's mem pool (and we need to transfer those). Seemed cleaner
not to special case these different cases.


-- 
To view, visit http://gerrit.cloudera.org:8080/3940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0955c85d18dfba4bd29a35ec95d0355da050607
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Christopher Channing <cchanning@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Christopher Channing <cchanning@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message