impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.
Date Thu, 11 Aug 2016 23:09:58 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.
......................................................................


Patch Set 7:

> By default, pytest captures test output, and as far as I can see,
 > it's not possible to turn that behavior off on a test by test
 > basis. You can do it globally if you run pytest with -s, but we
 > don't want to do that. Our tests are very chatty.
 > 
 > For what it's worth, I really do think this would be a very
 > unlikely thing to have happen -- for the .so file to go missing.

I was thinking more of the scenario where we rename the lzo so for some reason and lose test
coverage because of that.

It's just that in the past we've done things like run the old agg/join jenkins build with
the wrong options so we weren't getting the coverage we thought, and it took months to notice.

But maybe I'm being overly paranoid.  I suppose this is automated so less likely to go wrong.
 But I'll leave it to you guys, just wanted to raise this potential issue.

-- 
To view, visit http://gerrit.cloudera.org:8080/3782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If61a7799205cd00d440196303a42db32c522f5b1
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message