impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3969: stress test: add option to set common query options
Date Thu, 11 Aug 2016 17:32:55 GMT
David Knupp has posted comments on this change.

Change subject: IMPALA-3969: stress test: add option to set common query options
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

Looks good, with an optional suggestion if you feel like following it.

http://gerrit.cloudera.org:8080/#/c/3887/4/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:

PS4, Line 1408: Ignoring {query_option} in common query options: '{opt}'
This is a minor suggestion. You might consider adding some explanation as to why these are
being ignored, i.e., that these are default options set by the stress test.


-- 
To view, visit http://gerrit.cloudera.org:8080/3887
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iada041aace60c218a12178d8f1b9a68ff29de72e
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message