impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found
Date Wed, 10 Aug 2016 21:35:36 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3833/6/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 313:     if (UNLIKELY(file_metadata_.num_rows < 0)) {
> would it be better to do this check upstream? are there no other code paths
Good point, moved it to ProcessFooter()


PS6, Line 317: CHECK_LE
> why CHECK?
Typo. Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50cf43195a7c582caa02c85ae400ea2256fa3a3b
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message