impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3969: stress test: add option to set common query options
Date Wed, 10 Aug 2016 21:28:00 GMT
David Knupp has posted comments on this change.

Change subject: IMPALA-3969: stress test: add option to set common query options
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3887/3/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:

PS3, Line 1367: Comma-delimited string of query options and values
I think argparse has a standard way of dealing with multiple command line arguments, rather
than using a comma-delimited string. Perhaps...

https://docs.python.org/3/library/argparse.html#nargs

Or maybe action='append' ?


-- 
To view, visit http://gerrit.cloudera.org:8080/3887
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iada041aace60c218a12178d8f1b9a68ff29de72e
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message