impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3946: fix MemPool integrity issues with empty chunks
Date Wed, 10 Aug 2016 18:58:38 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3838/2/be/src/runtime/mem-pool.cc
File be/src/runtime/mem-pool.cc:

PS2, Line 265: if (current_chunk_empty) DCHECK_EQ(chunks_[i].allocated_bytes, 0);
> Please add a comment stating that !current_chunk_empty doesn't imply the cu
Did the rename. I already had a header comment that explains what current_chunk_empty means.
Is it clear enough with the variable rename and the header comment? I wrote another comment
here but it seemed redundant.


-- 
To view, visit http://gerrit.cloudera.org:8080/3838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message