impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3923: fix overflow in BufferedTupleStream::GetRows()
Date Wed, 10 Aug 2016 17:12:03 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3923: fix overflow in BufferedTupleStream::GetRows()
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3878/1//COMMIT_MSG
Commit Message:

PS1, Line 7: IMPALA-2923
> 3923
Done


http://gerrit.cloudera.org:8080/#/c/3878/1/be/src/runtime/buffered-tuple-stream-test.cc
File be/src/runtime/buffered-tuple-stream-test.cc:

Line 761: TEST_F(SimpleTupleStreamTest, TestGetRowsOverflow) {
I came up with a simpler but less realistic test that exercises the code path.


-- 
To view, visit http://gerrit.cloudera.org:8080/3878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabb977014d855d6edb035bf2e9519ac8b3234767
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message