impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3943: Adhere to abort on error when a Parquet file has no row groups.
Date Mon, 08 Aug 2016 23:34:06 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3943: Adhere to abort_on_error when a Parquet file has no row groups.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3862/1/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

PS1, Line 178:   if (!status.ok()) RETURN_IF_ERROR(state_->LogOrReturnError(status.msg()));
> This means a number of other errors are also handled in this way now. Are w
It seems like if we hit an error here we don't want to continue any processing of the file.
E.g. maybe we should just short-circuit GetNext() in this case.


-- 
To view, visit http://gerrit.cloudera.org:8080/3862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aff766a1ce6376efb329bdde51c648149dfe08c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message