impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3924: Ubuntu16 support
Date Mon, 08 Aug 2016 19:17:23 GMT
Thomas Tauber-Marshall has uploaded a new patch set (#4).

Change subject: IMPALA-3924: Ubuntu16 support
......................................................................

IMPALA-3924: Ubuntu16 support

One problem uncovered while trying to build Impala on Ubuntu16 is
that the functions 'isnan' and 'isinf' both appear in std::
(from <cmath>) and in boost::math::, but we're currently using
them without qualifiers in several places, leading to a conflict.

This patch prefaces all uses with 'std::' to disambiguate, and also
adds <cmath> imports to all files that use those functions, for
the sake of explicitness.

Another problem is that bin/make_impala.sh uses the system cmake,
which may not be compatible with the toolchain binaries. This patch
updates impala-config.sh to add the toolchain cmake to PATH, so
that we'll use it wherever we use cmake.

Change-Id: Iaa1520c1e4aa4175468ac342b14c1262fa745f7a
---
M be/src/exprs/cast-functions-ir.cc
M be/src/exprs/udf-builtins-ir.cc
M be/src/runtime/raw-value-ir.cc
M be/src/runtime/raw-value.inline.h
M be/src/util/metrics-test.cc
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
7 files changed, 21 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/3800/4
-- 
To view, visit http://gerrit.cloudera.org:8080/3800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa1520c1e4aa4175468ac342b14c1262fa745f7a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>

Mime
View raw message