impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2878: Fix Base64Decode error and remove duplicate codes.
Date Sat, 06 Aug 2016 02:40:47 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-2878: Fix Base64Decode error and remove duplicate codes.
......................................................................


IMPALA-2878: Fix Base64Decode error and remove duplicate codes.

Original impala::Base64Decode() method wouldn't return original
string if there were trailing '\0'. For example, string "a\0" would
be encoded into "YQA=", while calling original Base64Decode() method,
the return value is "a", which losts the trailing '\0' of original
string "a\0". Besides, this commit remove duplicate codes of function
impala::Base64En/Decode() and impala::StringFunctions::Base64En/Decode()

Change-Id: I0170a7d180ab048d0ff2196a24ddc53626aa7aab
Reviewed-on: http://gerrit.cloudera.org:8080/3824
Reviewed-by: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>
Reviewed-by: Jim Apple <jbapple@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/exec/hdfs-table-sink.cc
M be/src/exprs/string-functions-ir.cc
M be/src/service/impala-http-handler.cc
M be/src/util/CMakeLists.txt
R be/src/util/coding-util-test.cc
R be/src/util/coding-util.cc
R be/src/util/coding-util.h
M be/src/util/runtime-profile.cc
M be/src/util/thread.cc
M be/src/util/webserver.cc
10 files changed, 124 insertions(+), 84 deletions(-)

Approvals:
  Jim Apple: Looks good to me, approved
  Yuanhao Luo: Looks good to me, but someone else must approve
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0170a7d180ab048d0ff2196a24ddc53626aa7aab
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>

Mime
View raw message