impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-2878: Fix Base64Decode error and remove duplicate codes.
Date Sat, 06 Aug 2016 02:40:47 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-2878: Fix Base64Decode error and remove duplicate codes.

IMPALA-2878: Fix Base64Decode error and remove duplicate codes.

Original impala::Base64Decode() method wouldn't return original
string if there were trailing '\0'. For example, string "a\0" would
be encoded into "YQA=", while calling original Base64Decode() method,
the return value is "a", which losts the trailing '\0' of original
string "a\0". Besides, this commit remove duplicate codes of function
impala::Base64En/Decode() and impala::StringFunctions::Base64En/Decode()

Change-Id: I0170a7d180ab048d0ff2196a24ddc53626aa7aab
Reviewed-by: Yuanhao Luo <>
Reviewed-by: Jim Apple <>
Tested-by: Internal Jenkins
M be/src/exec/
M be/src/exprs/
M be/src/service/
M be/src/util/CMakeLists.txt
R be/src/util/
R be/src/util/
R be/src/util/coding-util.h
M be/src/util/
M be/src/util/
M be/src/util/
10 files changed, 124 insertions(+), 84 deletions(-)

  Jim Apple: Looks good to me, approved
  Yuanhao Luo: Looks good to me, but someone else must approve
  Internal Jenkins: Verified

To view, visit
To unsubscribe, visit

Gerrit-MessageType: merged
Gerrit-Change-Id: I0170a7d180ab048d0ff2196a24ddc53626aa7aab
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Yuanhao Luo <>

View raw message