impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3829: OpenSession() logs errors on valid configuration keys
Date Fri, 05 Aug 2016 23:49:29 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration keys
......................................................................


Patch Set 1: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3808/1/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:

Line 636:             << PrettyPrinter::Print(state->session_timeout, TUnit::TIME_S);
nit: please align with << in previous line


Line 639:         // Ignore failure (failures will be logged in SetQueryOption).
nit: SetQueryOption() (we use parentheses to make it obvious this refers to a function).


http://gerrit.cloudera.org:8080/#/c/3808/1/tests/hs2/test_hs2.py
File tests/hs2/test_hs2.py:

PS1, Line 42: assert open_session_resp.configuration['MAX_ERRORS'] == '45678'
            :     assert open_session_resp.configuration['NUM_NODES'] == '1234'
            :     assert open_session_resp.configuration['MAX_NUM_RUNTIME_FILTERS'] == '333'
small observation: to avoid typos, you might prefer:

  for k, v in open_session_req.configuration:
    assert open_session_resp[k] == v


-- 
To view, visit http://gerrit.cloudera.org:8080/3808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa9b823abc39ba9809a35a6f0844fa3436f1e025
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message