Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <tencent_2B63564E5A52D6F61AC8D2E2@qq.com>
References: <tencent_2B63564E5A52D6F61AC8D2E2@qq.com>
From: Jim Apple <jbapple@cloudera.com>
Date: Wed, 13 Jul 2016 18:19:21 -0700
Message-ID: <CAC-pSX3rGRAjOf74S3AdyNkMRBZbN+72Csc2ibhf5gTFCvd+WQ@mail.gmail.com>
Subject: Re: IMPALA-2428 Support multiple-character string as the field delimiter
To: dev@impala.incubator.apache.org
Content-Type: text/plain; charset=UTF-8
archived-at: Thu, 14 Jul 2016 01:20:07 -0000

Can you please put your design here, rather than just telling us where
you pasted it?

On Tue, Jul 12, 2016 at 4:33 AM, Yuanhao Luo
<luoyuanhao@software.ict.ac.cn> wrote:
> Hello, everyone. To fix IMPALA-2428 , I have push a commit to gerrit.
> I have illustrated my design in detail in IMPALA-2428 and there are also some test logs. Please read them carefully.
>
>
> The key point is that there are four constrains on multi-byte field terminator as below:
>
> Field terminator can't be an empty string
>
> Line terminators can't be the first byte of field terminator.
>
> Escape character can't be the first byte of field terminator.
>
> Terminators can't not contain '\0' for text file.
>
> As suggested by Jim Apple, I start this discussion in mailing list to do a design review.
> Are there any problems in my design?