Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 30809200B5C for ; Thu, 28 Jul 2016 01:54:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2F18D160A93; Wed, 27 Jul 2016 23:54:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7E13C160A90 for ; Thu, 28 Jul 2016 01:54:11 +0200 (CEST) Received: (qmail 56844 invoked by uid 500); 27 Jul 2016 23:54:10 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 56826 invoked by uid 99); 27 Jul 2016 23:54:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jul 2016 23:54:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1C87E1A541E for ; Wed, 27 Jul 2016 23:54:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id UduhSdfJAtww for ; Wed, 27 Jul 2016 23:54:08 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 557795FAE8 for ; Wed, 27 Jul 2016 23:54:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u6RNs6EH012167; Wed, 27 Jul 2016 23:54:06 GMT Message-Id: <201607272354.u6RNs6EH012167@ip-10-146-233-104.ec2.internal> Date: Wed, 27 Jul 2016 23:54:06 +0000 From: "Matthew Jacobs (Code Review)" To: Thomas Tauber-Marshall , impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: mj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_CDH-41931=3A_Toolchain_for_Ubuntu16_Impala_builds=0A?= X-Gerrit-Change-Id: Iaa1520c1e4aa4175468ac342b14c1262fa745f7a X-Gerrit-ChangeURL: X-Gerrit-Commit: ec8fadf33d2de1aa7ee36b07d2851d92fe2d9e60 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 27 Jul 2016 23:54:12 -0000 Matthew Jacobs has posted comments on this change. Change subject: CDH-41931: Toolchain for Ubuntu16 Impala builds ...................................................................... Patch Set 1: (1 comment) How about the change to use the cmake from the toolchain? http://gerrit.cloudera.org:8080/#/c/3800/1/be/src/runtime/raw-value.inline.h File be/src/runtime/raw-value.inline.h: Line 22: #include can you move this above the boost include? I found that the order mattered in at least one case. I think it's OK to put std lib includes above other libraries. You can put an extra blank line between them to indicate its a different group. -- To view, visit http://gerrit.cloudera.org:8080/3800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa1520c1e4aa4175468ac342b14c1262fa745f7a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes