Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BADFC200B58 for ; Wed, 27 Jul 2016 18:05:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B9A3F160A90; Wed, 27 Jul 2016 16:05:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0A944160A6F for ; Wed, 27 Jul 2016 18:05:58 +0200 (CEST) Received: (qmail 6089 invoked by uid 500); 27 Jul 2016 16:05:58 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 6078 invoked by uid 99); 27 Jul 2016 16:05:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jul 2016 16:05:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 894ECC0373 for ; Wed, 27 Jul 2016 16:05:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id A4pQijrTRpPk for ; Wed, 27 Jul 2016 16:05:55 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 877BB5FC8B for ; Wed, 27 Jul 2016 16:05:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u6RG5sdD026994; Wed, 27 Jul 2016 16:05:54 GMT Message-Id: <201607271605.u6RG5sdD026994@ip-10-146-233-104.ec2.internal> Date: Wed, 27 Jul 2016 16:05:54 +0000 From: "Tim Armstrong (Code Review)" To: Youwei Wang , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Alex Behm , Marcel Kornacker , Mostafa Mokhtar , Jim Apple Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-2809=3A_Improve_ByteSwap_with_builtin_function_or_SSSE3_or_AVX2=2E=0A?= X-Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2d7fa69e8c2b70e4fc72c6737e1e02b482e95485 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 27 Jul 2016 16:05:59 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. ...................................................................... Patch Set 38: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3081/36/be/src/util/bit-util.cc File be/src/util/bit-util.cc: Line 203: if (LIKELY(len < 16)) { > Hi Tim. Thanks for doing the experiment - it seems like it's beneficial. Just wanted to make sure this was an evidence-based decision. -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 38 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Youwei Wang Gerrit-HasComments: Yes