Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 37D44200B5E for ; Wed, 27 Jul 2016 01:30:40 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 365E1160AA5; Tue, 26 Jul 2016 23:30:40 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4EDE9160AA4 for ; Wed, 27 Jul 2016 01:30:39 +0200 (CEST) Received: (qmail 14558 invoked by uid 500); 26 Jul 2016 23:30:36 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 13933 invoked by uid 99); 26 Jul 2016 23:30:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jul 2016 23:30:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DCC85CC39E for ; Tue, 26 Jul 2016 23:30:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id aAenZAGiIsFS for ; Tue, 26 Jul 2016 23:30:32 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 708ED5FE66 for ; Tue, 26 Jul 2016 23:30:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u6QNUT3f012792; Tue, 26 Jul 2016 23:30:29 GMT Message-Id: <201607262330.u6QNUT3f012792@ip-10-146-233-104.ec2.internal> Date: Tue, 26 Jul 2016 23:30:29 +0000 From: "Marcel Kornacker (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dan Hecht Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3201=3A_HEADER_ONLY=3A_buffer_pool=0A?= X-Gerrit-Change-Id: Id771dea2eb4c1aa13c30d59e8b184a7d1bca8d34 X-Gerrit-ChangeURL: X-Gerrit-Commit: b61b8dd31c063fb28dabf3e09385e10a2d4fe56c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 26 Jul 2016 23:30:40 -0000 Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3201: HEADER ONLY: buffer pool ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3688/2/be/src/bufferpool/buffer-pool.h File be/src/bufferpool/buffer-pool.h: Line 303: uint8_t* buf() const; PageHandle should not have this function. all access of the underlying data needs to go through the buffer abstraction (otherwise you don't really have a separation of abstractions). algorithms that only implement data processing logic should only deal with buffers, whereas algorithms that only implement spilling-type logic should only deal with pages. -- To view, visit http://gerrit.cloudera.org:8080/3688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id771dea2eb4c1aa13c30d59e8b184a7d1bca8d34 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes