Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201607230605.u6N653uG013631@ip-10-146-233-104.ec2.internal>
Date: Sat, 23 Jul 2016 06:05:03 +0000
From: "Yuanhao Luo (Code Review)" <gerrit@cloudera.org>
To: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>,
        Jim Apple <jbapple@cloudera.com>, impala-cr@cloudera.com,
        dev@impala.incubator.apache.org
CC: Huaisi Xu <hxu@cloudera.com>, Marcel Kornacker <marcel@cloudera.com>,
        Henry Robinson <henry@cloudera.com>, Dan Hecht <dhecht@cloudera.com>,
        Tim Armstrong <tarmstrong@cloudera.com>
Reply-To: luoyuanhao@software.ict.ac.cn
Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-2878=3A_Fix_Base64Decode_error_and_remove_duplicate_codes=2E=0A?=
In-Reply-To: <gerrit.1465041614000.Ica8f61fce7af16aa859f71d0763303e8d832ddcd@gerrit.cloudera.org>
References: <gerrit.1465041614000.Ica8f61fce7af16aa859f71d0763303e8d832ddcd@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Sat, 23 Jul 2016 06:05:13 -0000

Hello Jim Apple,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3311

to look at the new patch set (#7).

Change subject: IMPALA-2878: Fix Base64Decode error and remove duplicate codes.
......................................................................

IMPALA-2878: Fix Base64Decode error and remove duplicate codes.

Original impala::Base64Decode() method wouldn't return original string if
there were trailing '\0'. For example, string "a\0" would be encoded into
"YQA=", while calling original Base64Decode() method, the return value
is "a", which losts the trailing '\0' of original string "a\0". Besides,
this commit remove duplicate codes of function impala::Base64En/Decode()
and impala::StringFunctions::Base64En/Decode().

Change-Id: Ica8f61fce7af16aa859f71d0763303e8d832ddcd
---
M be/src/exec/hdfs-table-sink.cc
M be/src/exprs/string-functions-ir.cc
M be/src/service/impala-http-handler.cc
M be/src/util/CMakeLists.txt
R be/src/util/coding-util-test.cc
R be/src/util/coding-util.cc
R be/src/util/coding-util.h
M be/src/util/runtime-profile.cc
M be/src/util/thread.cc
M be/src/util/webserver.cc
10 files changed, 116 insertions(+), 84 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/11/3311/7
-- 
To view, visit http://gerrit.cloudera.org:8080/3311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica8f61fce7af16aa859f71d0763303e8d832ddcd
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>