Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C2033200B4A for ; Wed, 20 Jul 2016 19:40:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C06A8160A64; Wed, 20 Jul 2016 17:40:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 107AD160A5B for ; Wed, 20 Jul 2016 19:40:10 +0200 (CEST) Received: (qmail 23632 invoked by uid 500); 20 Jul 2016 17:40:10 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 23620 invoked by uid 99); 20 Jul 2016 17:40:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jul 2016 17:40:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 95073C0B66 for ; Wed, 20 Jul 2016 17:40:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id jwpquDLdJ3Qu for ; Wed, 20 Jul 2016 17:40:07 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 95FFC5FD8A for ; Wed, 20 Jul 2016 17:40:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u6KHe6EK031879; Wed, 20 Jul 2016 17:40:06 GMT Message-Id: <201607201740.u6KHe6EK031879@ip-10-146-233-104.ec2.internal> Date: Wed, 20 Jul 2016 17:40:06 +0000 From: "Dan Hecht (Code Review)" To: Michael Ho , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Alex Behm Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3854=3A_Fix_use-after-free_in_HdfsTextScanner=3A=3AClose=28=29=0A?= X-Gerrit-Change-Id: Ia88f6285563ff669ae215af22ed2d45e5398adae X-Gerrit-ChangeURL: X-Gerrit-Commit: 27be23bfded5d1b0c5bd802ff5ce356f9a7a5d20 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 20 Jul 2016 17:40:11 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close() ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3630/4//COMMIT_MSG Commit Message: PS4, Line 23: ClearlStreams typo http://gerrit.cloudera.org:8080/#/c/3630/4/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: PS4, Line 194: decompression_type_ it looks like this is only set in ProcessSplit() if we found a tuple starting in the range. in the case we don't, will this still work okay? (I think it's okay, but just want to double check) -- To view, visit http://gerrit.cloudera.org:8080/3630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia88f6285563ff669ae215af22ed2d45e5398adae Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-HasComments: Yes