Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 158B4200B4A for ; Wed, 20 Jul 2016 19:22:32 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 12814160A5B; Wed, 20 Jul 2016 17:22:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5A867160A86 for ; Wed, 20 Jul 2016 19:22:31 +0200 (CEST) Received: (qmail 44266 invoked by uid 500); 20 Jul 2016 17:22:30 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 44195 invoked by uid 99); 20 Jul 2016 17:22:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jul 2016 17:22:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E5D251A5565 for ; Wed, 20 Jul 2016 17:22:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id s8ynhfKgY7h3 for ; Wed, 20 Jul 2016 17:22:28 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id B2D945FDE7 for ; Wed, 20 Jul 2016 17:22:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u6KHMQYQ031124; Wed, 20 Jul 2016 17:22:26 GMT Message-Id: <201607201722.u6KHMQYQ031124@ip-10-146-233-104.ec2.internal> Date: Wed, 20 Jul 2016 17:22:26 +0000 From: "Attila Jeges (Code Review)" To: Michael Ho , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Jim Apple , Lars Volker Reply-To: attilaj@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3829=3A_OpenSession=28=29_logs_errors_on_valid_configuration_keys=0A?= X-Gerrit-Change-Id: Ifa9b823abc39ba9809a35a6f0844fa3436f1e025 X-Gerrit-ChangeURL: X-Gerrit-Commit: b260247c5a8db37aa88e1d8342603ae4e1960f28 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 20 Jul 2016 17:22:32 -0000 Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3662 to look at the new patch set (#3). Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration keys ...................................................................... IMPALA-3829: OpenSession() logs errors on valid configuration keys Refactored OpenSession() to process the supplied configuration map in one loop. Call SetQueryOption() on normal configuration keys only. Other changes: - Compare config keys to "impala.doas.user" in case-insensitive manner. - New E2E test to check that setting query options still works after the change. Change-Id: Ifa9b823abc39ba9809a35a6f0844fa3436f1e025 --- M be/src/service/impala-hs2-server.cc M tests/hs2/test_hs2.py 2 files changed, 40 insertions(+), 33 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/62/3662/3 -- To view, visit http://gerrit.cloudera.org:8080/3662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifa9b823abc39ba9809a35a6f0844fa3436f1e025 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho