Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201607192314.u6JNEWKE015358@ip-10-146-233-104.ec2.internal>
Date: Tue, 19 Jul 2016 23:14:32 +0000
From: "Alex Behm (Code Review)" <gerrit@cloudera.org>
To: Lars Volker <lv@cloudera.com>, impala-cr@cloudera.com,
        dev@impala.incubator.apache.org
CC: Dan Hecht <dhecht@cloudera.com>, Marcel Kornacker <marcel@cloudera.com>,
        Bharath Vissapragada <bharathv@cloudera.com>
Reply-To: alex.behm@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3776=3A_fix_=27describe_formatted=27_for_Avro_tables=0A?=
In-Reply-To: <gerrit.1466716464000.Ic640f18acf7a1731f34b22c50ebbb462dfee78bd@gerrit.cloudera.org>
References: <gerrit.1466716464000.Ic640f18acf7a1731f34b22c50ebbb462dfee78bd@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Tue, 19 Jul 2016 23:14:39 -0000

Alex Behm has posted comments on this change.

Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables
......................................................................


Patch Set 2:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/3474/2//COMMIT_MSG
Commit Message:

Line 7: IMPALA-3776: fix 'describe formatted' for Avro tables
For both cases below, is our output consistent with the regular describe (without formatted)?


Line 11: 'avro.schema.url' file. HIVE-6308 aimed to improve upon this, but for
Instead of 'avro.schema'url' let's just say Avro Schema because there are other ways of specifying an Avro Schema (e.g. avro.schema.literal)


Line 21: 2) The avro schema contains a column, which is not present in the
Did this second case also have a bug that was fixed, or did it already work?


Line 25: I don't know how to automatically test this, but I verified this
I think you might be able to test case 1) as follows:
- create an Avro table only with column definitions (no Avro schema)
- alter the table to give it an Avro schema that has fewer columns (use avro.schema.litera; for convenience)
- invalidate metadata on the table
- run describe formatted


http://gerrit.cloudera.org:8080/#/c/3474/2/fe/src/main/java/com/cloudera/impala/service/DescribeResultFactory.java
File fe/src/main/java/com/cloudera/impala/service/DescribeResultFactory.java:

Line 187:     // table.
table which has already reconciled those differences.


Line 189:     msTable.setPartitionKeys(Column.toFieldSchemas(table.getClusteringColumns()));
Nice solution!


-- 
To view, visit http://gerrit.cloudera.org:8080/3474
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic640f18acf7a1731f34b22c50ebbb462dfee78bd
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes