Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0EB7D200B43 for ; Tue, 19 Jul 2016 17:27:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E3B2D160A8C; Tue, 19 Jul 2016 15:27:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 32968160A5C for ; Tue, 19 Jul 2016 17:27:26 +0200 (CEST) Received: (qmail 41131 invoked by uid 500); 19 Jul 2016 15:27:25 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 41120 invoked by uid 99); 19 Jul 2016 15:27:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Jul 2016 15:27:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C2A92D039D for ; Tue, 19 Jul 2016 15:27:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id zLor-6AxqV2Y for ; Tue, 19 Jul 2016 15:27:23 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id DD6E25F366 for ; Tue, 19 Jul 2016 15:27:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u6JFRK2r030744; Tue, 19 Jul 2016 15:27:20 GMT Message-Id: <201607191527.u6JFRK2r030744@ip-10-146-233-104.ec2.internal> Date: Tue, 19 Jul 2016 15:27:20 +0000 From: "Tim Armstrong (Code Review)" To: Kathy Sun , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Henry Robinson Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3716=3A_Add_Memory_Tab_in_query=27s_Details_page=0A?= X-Gerrit-Change-Id: I86db096ab7a022d230018becdb60bcc3056847af X-Gerrit-ChangeURL: X-Gerrit-Commit: 31bb3b82baa38ed7266058bb93ae0b7126441b24 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 19 Jul 2016 15:27:27 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-3716: Add Memory Tab in query's Details page ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3664/3/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: Line 254: lock_guard l(*exec_state->lock(), adopt_lock_t()); Also there's 4 spaces indent here instead of 2. Line 264: mem_usage_text = "The query is finished, current memory consumption is not available."; > Missed the long line here. Should be 90 characters or less. 4 spaces indent -- To view, visit http://gerrit.cloudera.org:8080/3664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86db096ab7a022d230018becdb60bcc3056847af Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Kathy Sun Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Kathy Sun Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes