Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A00B6200B48 for ; Mon, 18 Jul 2016 20:13:40 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9E9D4160A6D; Mon, 18 Jul 2016 18:13:40 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E8389160A65 for ; Mon, 18 Jul 2016 20:13:39 +0200 (CEST) Received: (qmail 3525 invoked by uid 500); 18 Jul 2016 18:13:28 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 3407 invoked by uid 99); 18 Jul 2016 18:13:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jul 2016 18:13:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C1D621A7E63 for ; Mon, 18 Jul 2016 18:13:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id elr_12MEBQUN for ; Mon, 18 Jul 2016 18:13:24 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 9648960D0A for ; Mon, 18 Jul 2016 18:13:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u6IIDMF9003069; Mon, 18 Jul 2016 18:13:22 GMT Message-Id: <201607181813.u6IIDMF9003069@ip-10-146-233-104.ec2.internal> Date: Mon, 18 Jul 2016 18:13:21 +0000 From: "Lars Volker (Code Review)" To: Thomas Tauber-Marshall , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Matthew Jacobs , Tim Armstrong Reply-To: lv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3376=3A_Extra_definition_level_when_writing_Parquet_files=0A?= X-Gerrit-Change-Id: I2cafd7ef6b607ce6f815072b8af7395a892704d9 X-Gerrit-ChangeURL: X-Gerrit-Commit: 51356a4dfa91e0b8d0a83009ff940ec52ff3a639 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Mon, 18 Jul 2016 18:13:40 -0000 Lars Volker has posted comments on this change. Change subject: IMPALA-3376: Extra definition level when writing Parquet files ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3556/4/be/src/util/parquet-reader.cc File be/src/util/parquet-reader.cc: Line 152: decompressed_buffer.reserve(header.uncompressed_page_size); I think you should call resize() so the buffer is actually initialized. Documentation for data() says "The pointer is such that range [data(); data() + size()) is always a valid range...". Just using reserve() means size() == 0 and then that guarantee wouldn't hold. -- To view, visit http://gerrit.cloudera.org:8080/3556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cafd7ef6b607ce6f815072b8af7395a892704d9 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes