Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D6DA8200B44 for ; Thu, 14 Jul 2016 18:30:37 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D5D3C160A63; Thu, 14 Jul 2016 16:30:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2B03A160A60 for ; Thu, 14 Jul 2016 18:30:37 +0200 (CEST) Received: (qmail 74267 invoked by uid 500); 14 Jul 2016 16:30:36 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 74256 invoked by uid 99); 14 Jul 2016 16:30:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jul 2016 16:30:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 962DFC05EF for ; Thu, 14 Jul 2016 16:30:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id zh7Uvv7EY_nc for ; Thu, 14 Jul 2016 16:30:31 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 6E5065F1E5 for ; Thu, 14 Jul 2016 16:30:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u6EGUUMd024235; Thu, 14 Jul 2016 16:30:30 GMT Message-Id: <201607141630.u6EGUUMd024235@ip-10-146-233-104.ec2.internal> Date: Thu, 14 Jul 2016 16:30:26 +0000 From: "Alex Behm (Code Review)" To: Marcel Kornacker , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Tim Armstrong Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3845=3A_Split_up_hdfs-parquet-scanner=2Ecc_into_more_files/components=2E=0A?= X-Gerrit-Change-Id: I4c5fd46f9c1a0ff2a4c30ea5a712fbae17c68f92 X-Gerrit-ChangeURL: X-Gerrit-Commit: 110751bffdf9319164d722d755152b9567d9b230 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 14 Jul 2016 16:30:38 -0000 Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3596 to look at the new patch set (#5). Change subject: IMPALA-3845: Split up hdfs-parquet-scanner.cc into more files/components. ...................................................................... IMPALA-3845: Split up hdfs-parquet-scanner.cc into more files/components. This patch refactors hdfs-parquet-scanner.cc into several files. The new responsibilities of each file/component are roughly as follows: hdfs-parquet-scanner.cc - Creates column readers aud uses them to materializes row batches. - Evaluates runtime filters and conjuncts, populates row batch queue. parquet-metadata-utils.h/cc - Contains utilities for validating Parquet file metadata. - Parses the schema of a Parquet file into our internal schema representation. - Resolves SchemaPaths (e.g. from a table descriptor) against the internal representation of the Parquet file schema. parquet-column-readers.h - Contains the per-column data reading, parsing and value materialization logic. Testing: A private core/hdfs run passed. Change-Id: I4c5fd46f9c1a0ff2a4c30ea5a712fbae17c68f92 --- M be/src/exec/CMakeLists.txt M be/src/exec/base-sequence-scanner.cc M be/src/exec/hdfs-parquet-scanner.cc M be/src/exec/hdfs-parquet-scanner.h M be/src/exec/hdfs-rcfile-scanner.cc M be/src/exec/hdfs-scanner.cc M be/src/exec/hdfs-scanner.h M be/src/exec/hdfs-text-scanner.cc A be/src/exec/parquet-column-readers.cc A be/src/exec/parquet-column-readers.h A be/src/exec/parquet-metadata-utils.cc A be/src/exec/parquet-metadata-utils.h A be/src/exec/parquet-scratch-tuple-batch.h M be/src/exprs/expr-value.h M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h M be/src/util/debug-util.cc M be/src/util/debug-util.h 18 files changed, 2,683 insertions(+), 2,462 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/96/3596/5 -- To view, visit http://gerrit.cloudera.org:8080/3596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c5fd46f9c1a0ff2a4c30ea5a712fbae17c68f92 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Tim Armstrong