Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C478E200B4D for ; Sat, 9 Jul 2016 03:04:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C2F5C160A77; Sat, 9 Jul 2016 01:04:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 15CB9160A5A for ; Sat, 9 Jul 2016 03:04:30 +0200 (CEST) Received: (qmail 69664 invoked by uid 500); 9 Jul 2016 01:04:30 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 69652 invoked by uid 99); 9 Jul 2016 01:04:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Jul 2016 01:04:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 90031C09CB for ; Sat, 9 Jul 2016 01:04:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Xc5E_ujd8c60 for ; Sat, 9 Jul 2016 01:04:27 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 540285FBC7 for ; Sat, 9 Jul 2016 01:04:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u6914PUQ026239; Sat, 9 Jul 2016 01:04:25 GMT Message-Id: <201607090104.u6914PUQ026239@ip-10-146-233-104.ec2.internal> Date: Sat, 9 Jul 2016 01:04:25 +0000 From: "Dan Hecht (Code Review)" To: Michael Ho , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Tim Armstrong Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-2885=3A_ScannerContext=3A=3AStream_objects_should_be_owned_by_ScannerContext=0A?= X-Gerrit-Change-Id: Ic5440d414ecc0ca19676c553275aeb85231d6045 X-Gerrit-ChangeURL: X-Gerrit-Commit: a275e3fbad4464f543e8536ead6519dedb030377 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Sat, 09 Jul 2016 01:04:31 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-2885: ScannerContext::Stream objects should be owned by ScannerContext ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3590/4/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 194: scan_node_->RangeComplete(THdfsFileFormat::TEXT, compression_type); is it important that RangeComplete() is called after AddFinalRowBatch(), or could we just move all of this code up? -- To view, visit http://gerrit.cloudera.org:8080/3590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5440d414ecc0ca19676c553275aeb85231d6045 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes