Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E0360200B35 for ; Tue, 5 Jul 2016 19:23:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id DE968160A60; Tue, 5 Jul 2016 17:23:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 325A5160A2C for ; Tue, 5 Jul 2016 19:23:10 +0200 (CEST) Received: (qmail 88511 invoked by uid 500); 5 Jul 2016 17:23:09 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 88498 invoked by uid 99); 5 Jul 2016 17:23:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jul 2016 17:23:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A3003C9E4F for ; Tue, 5 Jul 2016 17:23:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 05XtYXkFOIBN for ; Tue, 5 Jul 2016 17:23:06 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id A395F5FE5E for ; Tue, 5 Jul 2016 17:23:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u65HN5mq002837; Tue, 5 Jul 2016 17:23:05 GMT Message-Id: <201607051723.u65HN5mq002837@ip-10-146-233-104.ec2.internal> Date: Tue, 5 Jul 2016 17:23:00 +0000 From: "Huaisi Xu (Code Review)" To: Dimitris Tsirogiannis , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Henry Robinson Reply-To: hxu@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3711=3A_Remove_unnecessary_privilege_checks_in_getDbsMetadata=28=29=0A?= X-Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8a006bde02c97864025ce4aa6827e4f76e734d15 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 05 Jul 2016 17:23:11 -0000 Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3371 to look at the new patch set (#18). Change subject: IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata() ...................................................................... IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata() Previously all code paths using getDbsMetadata() sufferred unnecessary privilege checks: 1. Impala checked privilege of all databases, tables before applying user provided JDBC pattern filters. 2. Impala passed a null pattern to getDbsMetadata() when user did not provide one. However, null pattern is treated as "%", which matches everything thereby causing unnecessary privilege checks for catalog objects that are not in the result set. This patch creates PatternMatcher early so that user specified null pattern is respected when calling getDbsMetadata(). Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 --- M fe/src/main/java/com/cloudera/impala/catalog/Catalog.java M fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/com/cloudera/impala/catalog/Db.java M fe/src/main/java/com/cloudera/impala/service/Frontend.java M fe/src/main/java/com/cloudera/impala/service/JniCatalog.java M fe/src/main/java/com/cloudera/impala/service/JniFrontend.java M fe/src/main/java/com/cloudera/impala/service/MetadataOp.java M fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java M fe/src/test/java/com/cloudera/impala/analysis/AuthorizationTest.java M fe/src/test/java/com/cloudera/impala/testutil/BlockIdGenerator.java M fe/src/test/java/com/cloudera/impala/testutil/ImpaladTestCatalog.java M testdata/workloads/functional-query/queries/QueryTest/show.test 12 files changed, 331 insertions(+), 142 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/71/3371/18 -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 18 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Huaisi Xu