Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5B4B7200B40 for ; Fri, 1 Jul 2016 20:26:51 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 59F27160A61; Fri, 1 Jul 2016 18:26:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A18A8160A4D for ; Fri, 1 Jul 2016 20:26:50 +0200 (CEST) Received: (qmail 14909 invoked by uid 500); 1 Jul 2016 18:26:49 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 14896 invoked by uid 99); 1 Jul 2016 18:26:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2016 18:26:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 39D9E180584 for ; Fri, 1 Jul 2016 18:26:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id aCKcdgzJDwQd for ; Fri, 1 Jul 2016 18:26:47 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 6DE9F5FB35 for ; Fri, 1 Jul 2016 18:26:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u61IQjCn032016; Fri, 1 Jul 2016 18:26:45 GMT Message-Id: <201607011826.u61IQjCn032016@ip-10-146-233-104.ec2.internal> Date: Fri, 1 Jul 2016 18:26:45 +0000 From: "Henry Robinson (Code Review)" To: Huaisi Xu , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dimitris Tsirogiannis Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3711=3A_Remove_unnecessary_privilege_checks_in_getDbsMetadata=28=29=0A?= X-Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 X-Gerrit-ChangeURL: X-Gerrit-Commit: 969a1dab9f3049ee11748ffca2328d0990e105e0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 01 Jul 2016 18:26:51 -0000 Henry Robinson has posted comments on this change. Change subject: IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata() ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/3371/15/fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java File fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java: PS15, Line 74: * Null pattern's matching is controlled by 'isNullMatchAll', where if it is set then : * null matches everything; unset otherwise. > if I understand correctly. this depends on we have a pattern that matches n So why does this extra parameter exist, if it's never used? -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 15 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Huaisi Xu Gerrit-HasComments: Yes