impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3861: Fix BetweenPredicate.clone() to preserve Expr reference structure.
Date Thu, 28 Jul 2016 08:13:51 GMT
Alex Behm has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3804

Change subject: IMPALA-3861: Fix BetweenPredicate.clone() to preserve Expr reference structure.
......................................................................

IMPALA-3861: Fix BetweenPredicate.clone() to preserve Expr reference structure.

The bug: The implementation of BetweenPredicate.clone() was not quite correct,
because it did not preserve the expr reference structure of the original object.
In particular, identical exprs are present within several structures in a
BetweenPredicate.
This incorrect cloning manifested itself as a failure to analyze a correlated
SlotRef which should have been substituted during subquery rewriting.

The fix is to preserve the original object reference structure when cloning.

Change-Id: I0838b30444ed9704ce6a058d30718a24caa7444a
---
M fe/src/main/java/com/cloudera/impala/analysis/BetweenPredicate.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeSubqueriesTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test
3 files changed, 59 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/3804/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0838b30444ed9704ce6a058d30718a24caa7444a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>

Mime
View raw message