impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3859: Don't log file data on parse errors
Date Thu, 14 Jul 2016 00:28:03 GMT
Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3646

Change subject: IMPALA-3859: Don't log file data on parse errors
......................................................................

IMPALA-3859: Don't log file data on parse errors

Logging file or table data is a bad idea, and doing it by default is
particularly bad. This patch changes HdfsScanNode::LogRowParseError() to
log a file and offset only.

Testing: There are tests that rely on the output of LogRowParseError()
that need to be rewritten or removed if this approach is agreed on.

Change-Id: I5a604f8784a9ff7b4bf878f82ee7f56697df3272
---
M be/src/exec/hdfs-scanner-ir.cc
M be/src/exec/hdfs-scanner.cc
M be/src/exec/hdfs-scanner.h
M be/src/exec/hdfs-sequence-scanner.cc
M be/src/exec/hdfs-sequence-scanner.h
M be/src/exec/hdfs-text-scanner.cc
M be/src/exec/hdfs-text-scanner.h
7 files changed, 17 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/46/3646/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3646
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a604f8784a9ff7b4bf878f82ee7f56697df3272
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <henry@cloudera.com>

Mime
View raw message